feat(cds-modal): new enable-dialog-element feature flag#22144
Open
maradwan26 wants to merge 11 commits intocarbon-design-system:mainfrom
Open
feat(cds-modal): new enable-dialog-element feature flag#22144maradwan26 wants to merge 11 commits intocarbon-design-system:mainfrom
enable-dialog-element feature flag#22144maradwan26 wants to merge 11 commits intocarbon-design-system:mainfrom
Conversation
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #22144 +/- ##
==========================================
+ Coverage 95.06% 95.10% +0.04%
==========================================
Files 541 543 +2
Lines 45217 45662 +445
Branches 6507 6563 +56
==========================================
+ Hits 42985 43428 +443
- Misses 2103 2104 +1
- Partials 129 130 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20540
Part of #19454
Adds
enable-dialog-elementfeature flag to@carbon/web-componentsChangelog
New
Added
modal-base.tsfilecds-modalandcds-dialogthat are then inherited by these componentscds-dialogextended directly fromcds-modal, but this caused dependency issues with this feature flag, so things have been moved tomodal-base, and now bothcds-dialogandcds-modalextendedmodal-baseinsteadAdded
enable-dialog-elementfeature flag and respectivemdxand storyChanged
enable-dialog-element, the borders from the Dialog and the Modal would stack, resulting in a 2px border.Testing / Reviewing
Modal/Feature Flagin Web Components storybookmodal-baseshould not cause any regressions to the Dialog or Modal componentscds-dialogevents are intentionally prevented from propagating (932f012) in favour of thecds-modalevents when using this feature flag, to keep adopters' event handling usages consistentPR Checklist
As the author of this PR, before marking ready for review, confirm you:
[ ] Wrote passing tests that cover this change