chore: output scoped-elements build folder for base class elements with scoped subcomponents#22145
Draft
annawen1 wants to merge 3 commits intocarbon-design-system:mainfrom
Draft
chore: output scoped-elements build folder for base class elements with scoped subcomponents#22145annawen1 wants to merge 3 commits intocarbon-design-system:mainfrom
scoped-elements build folder for base class elements with scoped subcomponents#22145annawen1 wants to merge 3 commits intocarbon-design-system:mainfrom
Conversation
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22145 +/- ##
==========================================
- Coverage 95.08% 95.06% -0.03%
==========================================
Files 541 541
Lines 45217 45239 +22
Branches 6560 6566 +6
==========================================
+ Hits 42996 43007 +11
- Misses 2092 2103 +11
Partials 129 129
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #17718
This PR adds a plugin file that is run in the Web Components' build. The plugin strips the
customElementdecorator from the component class files so that the components don't self-register into the global custom element registry. For components that have subcomponents (ie.cds-accordion-skeletonusescds-accordion-item-skeleton), we use theCustomElementRegistryAPI to create a scoped custom registry and scope the subcomponents to the parent component.Changelog
New
Changed
Removed
Testing / Reviewing
{{ Add steps or a checklist for how reviewers can verify this PR works or not }}
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
More details can be found in the pull request guide