Skip to content

feat: add support for TypeScript stories in @carbon/react#22149

Open
adamalston wants to merge 2 commits intocarbon-design-system:mainfrom
adamalston:n/a-typescript-stories
Open

feat: add support for TypeScript stories in @carbon/react#22149
adamalston wants to merge 2 commits intocarbon-design-system:mainfrom
adamalston:n/a-typescript-stories

Conversation

@adamalston
Copy link
Copy Markdown
Contributor

No issue. Perhaps I should open an issue to house all of these story migrations. If anyone has thoughts, let me know.

Added support for TypeScript stories in @carbon/react.

Changelog

New

  • Added support for TypeScript stories in @carbon/react.

Changed

  • Fixed the type and behavior issues in the Controlled Accordion story.

Removed

  • Removed the reference to storyStoreV7 since it was outdated.

Testing / Reviewing

I migrated one story in this pull request to TypeScript, the Accordion story. While addressing a type issue in the Controlled story, I also fixed a bug in the open all and close all functionality. I don’t expect future story migrations to TypeScript to require this many changes, and I may batch them if the required updates are small.

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • Wrote passing tests that cover this change
  • Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 30, 2026

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d11bcad
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/69f2c3bc1cf30c00083ca52d
😎 Deploy Preview https://deploy-preview-22149--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 30, 2026

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit d11bcad
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/69f2c3bc8c1d3400088baa58
😎 Deploy Preview https://deploy-preview-22149--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

❌ Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.99%. Comparing base (cb5b293) to head (d11bcad).

Files with missing lines Patch % Lines
...act/src/components/Accordion/Accordion.stories.tsx 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22149      +/-   ##
==========================================
- Coverage   95.06%   94.99%   -0.07%     
==========================================
  Files         541      542       +1     
  Lines       45217    45259      +42     
  Branches     6507     6563      +56     
==========================================
+ Hits        42985    42996      +11     
- Misses       2103     2134      +31     
  Partials      129      129              
Flag Coverage Δ
main-packages 88.87% <0.00%> (-0.26%) ⬇️
web-components 97.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant