feat: add support for TypeScript stories in @carbon/react#22149
Open
adamalston wants to merge 2 commits intocarbon-design-system:mainfrom
Open
feat: add support for TypeScript stories in @carbon/react#22149adamalston wants to merge 2 commits intocarbon-design-system:mainfrom
adamalston wants to merge 2 commits intocarbon-design-system:mainfrom
Conversation
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #22149 +/- ##
==========================================
- Coverage 95.06% 94.99% -0.07%
==========================================
Files 541 542 +1
Lines 45217 45259 +42
Branches 6507 6563 +56
==========================================
+ Hits 42985 42996 +11
- Misses 2103 2134 +31
Partials 129 129
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No issue. Perhaps I should open an issue to house all of these story migrations. If anyone has thoughts, let me know.
Added support for TypeScript stories in
@carbon/react.Changelog
New
@carbon/react.Changed
ControlledAccordionstory.Removed
storyStoreV7since it was outdated.Testing / Reviewing
I migrated one story in this pull request to TypeScript, the
Accordionstory. While addressing a type issue in theControlledstory, I also fixed a bug in the open all and close all functionality. I don’t expect future story migrations to TypeScript to require this many changes, and I may batch them if the required updates are small.PR Checklist
As the author of this PR, before marking ready for review, confirm you:
Wrote passing tests that cover this changeAddressed any impact on accessibility (a11y)More details can be found in the pull request guide