Feat/proper rollback handling - #54
Open
flowftw wants to merge 4 commits into
Open
Conversation
Instead of dropping all AdaHandles and recalculating from scratch on rollback, drop only those that were affected by rollback or restore them to there last known state based on the history.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the rollback handler in order to make it more efficient. Instead of dropping all adahandles and recalculating the table from scratch only effected adahandles are removed or replaced with the last entry from the history table before the rollback slot.
In addition the PR fixes some minor issues in the deployment.