fix(android): map BIKING_STATIONARY for Health Connect workouts#477
Open
georgemac-labs wants to merge 1 commit intocarp-dk:mainfrom
Open
fix(android): map BIKING_STATIONARY for Health Connect workouts#477georgemac-labs wants to merge 1 commit intocarp-dk:mainfrom
georgemac-labs wants to merge 1 commit intocarp-dk:mainfrom
Conversation
georgemac-labs
changed the title
georgemac-labs
force-pushed
the
fix/android-workout-type-map-parity
branch
from
70692b7 to
d558055
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Android Health Connect workout writing for
BIKING_STATIONARY.HealthWorkoutActivityType.BIKING_STATIONARYis exposed in Dart and marked Android-supported,but native write validation failed with:
[Health Connect] Workout type not supportedRoot cause
Android workout writes validate activity type strings against
HealthConstants.workoutTypeMap.BIKING_STATIONARYwas missing from that map.Change
Added one mapping in
android/src/main/kotlin/cachet/plugins/health/HealthConstants.kt:BIKING_STATIONARY -> ExerciseSessionRecord.EXERCISE_TYPE_BIKING_STATIONARYNotes
Other candidate mappings were intentionally not included because this plugin targets an older
Health Connect version where those constants are not available.
Verification
flutter analyze.