Add per-workout flights climbed and swimming stroke count - #495
Open
zkrige wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Exposes two per-workout HealthKit totals that were not previously surfaced by the plugin:
HKWorkout.totalFlightsClimbed)HKWorkout.totalSwimmingStrokeCount)Both are direct
HKWorkoutproperties. The workout'sduration(seconds) is also added to the emitted dictionary for completeness.Changes
iOS (
ios/Classes/HealthDataReader.swift) — both[HKWorkout]branches (the list read used bygetHealthDataFromTypesand the single-sample read) now emittotalFlightsClimbed,totalSwimmingStrokeCount(inHKUnit.count(), null when the property is nil), andduration.Dart (
lib/src/health_value_types.dart) —WorkoutHealthValuegains nullableint? totalFlightsClimbedandint? totalSwimmingStrokeCountfields, parsed infromHealthDataPointmirroringtotalSteps/totalDistance, and wired into the constructor,toString,==, andhashCode.Generated (
lib/health.g.dart) — regenerated viadart run build_runner buildto include the new fields in JSON (de)serialization.These are additive and nullable, so existing consumers are unaffected. Values are null on Android (HealthKit-only properties).