Removes the <5 pin from the redis dependency
#58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redis is beyond version 5 now, but including `flipper-client` is holding our redis dependency back. Here we unpin it, bump `fakeredis`, and also put a new pin on `moto`, which had a significant change in 4.2 that will require some rewriting of tests to address.
|
I created a fork https://github.com/felippemr/felipper-client. You should be able to replace 1:1 https://pypi.org/project/felipper_client/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redis is beyond version 5 now, but including
flipper-clientis holdingour redis dependency back. Here we unpin it, bump
fakeredis, and alsoput a new pin on
moto, which had a significant change in 4.2 that willrequire some rewriting of tests to address.