-
Notifications
You must be signed in to change notification settings - Fork 13
Fix development environment issues #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR aims to improve the development environment by pinning dependency versions to avoid major version issues, updating dependency sources to reference GitHub, and configuring MyPy settings.
- Update dependency versions and constraints in setup.py
- Add MyPy configuration in pyproject.toml
- Update flake8 repository URL in .pre-commit-config.yaml
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| setup.py | Pin versions for multiple dependencies to enforce v4 for moto and consistent versioning for others |
| pyproject.toml | Add MyPy configuration settings for namespace_packages and explicit_package_bases |
| .pre-commit-config.yaml | Change flake8 repository from GitLab to GitHub |
|
I ran into an unexpected issue while reviewing this PR. Please try again later. |
Problems
motois used in tests for S3 and v5 has a breaking change compared to v4. Other dev dependencies are also not pinned.testing.postgreshasn't been updated since 2015 and fails.blackhook was failing due to re-formatting of tests.flipper-clientis not a valid Python package name.redisandcachetools.Solutions
blackand formatted tests.flipper-clientand don't change the existing package name.