Skip to content

Conversation

@markmeleka
Copy link

@markmeleka markmeleka commented May 24, 2025

Problems

  1. moto is used in tests for S3 and v5 has a breaking change compared to v4. Other dev dependencies are also not pinned.
  2. All dependencies reference packages in Github, except one, which requires Gitlab.
  3. testing.postgres hasn't been updated since 2015 and fails.
  4. The black hook was failing due to re-formatting of tests.
  5. MyPy complains that flipper-client is not a valid Python package name.
  6. MyPy was failing when requesting stubs for redis and cachetools.

Solutions

  1. Pin dependencies to avoid major version issues.
  2. Update remaining package to point to github version.
  3. Upgrade to pytest-postgresql and set up postgres in CI.
  4. Updated black and formatted tests.
  5. Ignore the MyPy error for flipper-client and don't change the existing package name.
  6. Ignored specific MyPy stub requests.

Copilot AI review requested due to automatic review settings May 24, 2025 01:35
@markmeleka markmeleka added the cc-tech debt Paying out technical debt. Examples: refactoring features for better extensibility. label May 24, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to improve the development environment by pinning dependency versions to avoid major version issues, updating dependency sources to reference GitHub, and configuring MyPy settings.

  • Update dependency versions and constraints in setup.py
  • Add MyPy configuration in pyproject.toml
  • Update flake8 repository URL in .pre-commit-config.yaml

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
setup.py Pin versions for multiple dependencies to enforce v4 for moto and consistent versioning for others
pyproject.toml Add MyPy configuration settings for namespace_packages and explicit_package_bases
.pre-commit-config.yaml Change flake8 repository from GitLab to GitHub

@windsurf-bot
Copy link

windsurf-bot bot commented May 24, 2025

I ran into an unexpected issue while reviewing this PR. Please try again later.

@markmeleka markmeleka changed the title Improve development environment Fix development environment issues May 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cc-tech debt Paying out technical debt. Examples: refactoring features for better extensibility.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants