Skip to content

Comments

Change default block to latest#186

Merged
tuler merged 1 commit intoprerelease/v2-alphafrom
feature/default-latest
Mar 17, 2025
Merged

Change default block to latest#186
tuler merged 1 commit intoprerelease/v2-alphafrom
feature/default-latest

Conversation

@tuler
Copy link
Member

@tuler tuler commented Mar 17, 2025

This changes the default node block to latest, instead of finalized.
As discussed on discord this is better for development.

We also discussed the possibility of printing a warn message.

@tuler tuler requested a review from endersonmaia March 17, 2025 17:19
@changeset-bot
Copy link

changeset-bot bot commented Mar 17, 2025

🦋 Changeset detected

Latest commit: dd856cf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cartesi/cli Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2025

Coverage Report for ./apps/cli

Status Category Percentage Covered / Total
🔵 Lines 27.43% 293 / 1068
🔵 Statements 27.41% 298 / 1087
🔵 Functions 27.27% 51 / 187
🔵 Branches 25.74% 121 / 470
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
apps/cli/src/commands/rollups/start.ts 0% 0% 0% 0% 11-298
Generated in workflow #375 for commit dd856cf by the Vitest Coverage Report Action

Base automatically changed from feature/always-verbose to prerelease/v2-alpha March 17, 2025 17:35
@tuler tuler force-pushed the feature/default-latest branch from 468f478 to adb89fb Compare March 17, 2025 17:40
@tuler tuler force-pushed the feature/default-latest branch from adb89fb to dd856cf Compare March 17, 2025 18:52
@tuler
Copy link
Member Author

tuler commented Mar 17, 2025

Added a warning, please check

@tuler tuler requested a review from endersonmaia March 17, 2025 18:52
@tuler tuler merged commit d8a569e into prerelease/v2-alpha Mar 17, 2025
2 checks passed
@tuler tuler deleted the feature/default-latest branch March 17, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants