Skip to content

Conversation

@tuler
Copy link
Member

@tuler tuler commented Mar 24, 2025

This PR uses a single GitHub Actions workflow for all 3 docker images produced by SDK.
First it uses a matrix job with the meta task to generate meta for all 3 images.
Then it uses a single bake action with multiple targets.
This strategy does not need a different docker cache strategy, as bake already provides that.

@tuler tuler requested a review from endersonmaia March 24, 2025 16:26
@changeset-bot
Copy link

changeset-bot bot commented Mar 24, 2025

⚠️ No Changeset found

Latest commit: d6c9129

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tuler tuler force-pushed the feature/single-sdk-workflow branch from 18ffc98 to 77fd71c Compare March 24, 2025 16:28
@socket-security
Copy link

socket-security bot commented Mar 24, 2025

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@endersonmaia endersonmaia changed the base branch from feat/cache-between-docker-targets to feature/additional-container-releases March 24, 2025 18:52
@github-actions
Copy link
Contributor

Coverage Report for ./apps/cli

Status Category Percentage Covered / Total
🔵 Lines 27.46% 293 / 1067
🔵 Statements 27.41% 298 / 1087
🔵 Functions 27.27% 51 / 187
🔵 Branches 25.74% 121 / 470
File CoverageNo changed files found.
Generated in workflow #401 for commit 6a1f908 by the Vitest Coverage Report Action

@endersonmaia endersonmaia force-pushed the feature/single-sdk-workflow branch from 6a1f908 to 797091f Compare March 24, 2025 18:59
@endersonmaia endersonmaia force-pushed the feature/additional-container-releases branch from dad7151 to adb7dc3 Compare March 24, 2025 19:01
@endersonmaia endersonmaia force-pushed the feature/single-sdk-workflow branch 3 times, most recently from d8ab794 to 11ebf47 Compare March 24, 2025 21:37
@tuler tuler force-pushed the feature/single-sdk-workflow branch from 465f416 to ddecfab Compare March 24, 2025 22:16
@tuler tuler force-pushed the feature/single-sdk-workflow branch from 19b4ded to d6c9129 Compare March 24, 2025 23:20
@tuler tuler marked this pull request as ready for review March 24, 2025 23:33
@tuler tuler merged commit 3437616 into feature/additional-container-releases Mar 24, 2025
7 checks passed
@tuler tuler deleted the feature/single-sdk-workflow branch March 24, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants