Skip to content

Conversation

@Nonnyjoe
Copy link
Member

@Nonnyjoe Nonnyjoe commented Sep 6, 2025

This PR adds support for single and batch ERC1155 deposits to applications via the CLI.

@changeset-bot
Copy link

changeset-bot bot commented Sep 6, 2025

🦋 Changeset detected

Latest commit: a1e98b1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cartesi/cli Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2025

Coverage Report for ./apps/cli

Status Category Percentage Covered / Total
🔵 Lines 23.28% 279 / 1198
🔵 Statements 23.16% 284 / 1226
🔵 Functions 24.5% 50 / 204
🔵 Branches 20% 112 / 560
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
apps/cli/src/commands/deposit.ts 0% 100% 0% 0% 11-48
apps/cli/src/commands/deposit/erc1155.ts 0% 0% 0% 0% 28-341
Generated in workflow #664 for commit a1e98b1 by the Vitest Coverage Report Action

@Nonnyjoe Nonnyjoe requested a review from tuler September 6, 2025 16:31
@Nonnyjoe Nonnyjoe requested a review from tuler September 18, 2025 13:16
@tuler
Copy link
Member

tuler commented Sep 18, 2025

Please squash both commits, and change the commit message to follow the repo other commits standard

@Nonnyjoe Nonnyjoe force-pushed the feature/erc1155_deposit branch from 7b0de2e to 6b65c4f Compare September 18, 2025 13:41
@Nonnyjoe Nonnyjoe changed the title Deposit support for erc1155 tokens Add erc1155 to deposit commands Sep 18, 2025
@Nonnyjoe Nonnyjoe requested review from tuler and removed request for tuler September 18, 2025 13:49
@tuler
Copy link
Member

tuler commented Sep 18, 2025

please change commit message to "feat(cli): add erc1155 to deposit commands"

@Nonnyjoe Nonnyjoe force-pushed the feature/erc1155_deposit branch from 6b65c4f to 8548c07 Compare September 18, 2025 14:16
@Nonnyjoe Nonnyjoe changed the title Add erc1155 to deposit commands feat(cli): add erc1155 to deposit commands Sep 18, 2025
@Nonnyjoe Nonnyjoe requested review from tuler and removed request for tuler September 18, 2025 14:21
@Nonnyjoe Nonnyjoe force-pushed the feature/erc1155_deposit branch from 8548c07 to 22474d3 Compare September 18, 2025 15:32
@Nonnyjoe Nonnyjoe requested a review from tuler September 18, 2025 15:34
@Nonnyjoe Nonnyjoe force-pushed the feature/erc1155_deposit branch from 22474d3 to a1e98b1 Compare September 18, 2025 16:16
@Nonnyjoe Nonnyjoe merged commit a540baf into prerelease/v2-alpha Sep 18, 2025
4 checks passed
@Nonnyjoe Nonnyjoe deleted the feature/erc1155_deposit branch September 18, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants