fix: advance result store logic #710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the logic for storing advance results by ensuring that outputs and reports are only persisted to the database when an input has an "Accepted" status. This aligns with the existing indexing logic that already filters by accepted status when calculating output and report indices.
Key changes:
- Conditional storage of outputs and reports based on input acceptance status
- Updated test application to generate a report before rejecting, validating the new logic
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/repository/postgres/bulk.go | Wraps insertOutputs and insertReports calls in a conditional check for InputCompletionStatus_Accepted, preventing storage of outputs/reports from rejected or exception inputs |
| Makefile | Updates the reject-dapp test application to generate a report with rejection reason before calling reject, allowing validation of the new conditional storage logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mpolitzer
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.