Install script improvements #656
Description
Activity
This would actually be true for all the tools so we should probably move this issue
Thanks for bringing this up! The ask is reasonable, but I believe we should see if folks run into this often.
If this is a recurring pain point then we would be open to working towards a solution 🙏🏼Reacted by David PCan I work on this project!
@Kiran-pro2001 Sure! Feel free to raise a PR.
As a matter of fact, the script is autogenerated from the template in https://github.com/carvel-dev/release-scripts/blob/main/scripts/install_sh/install.sh.txt, so any change should be done there.
Reacted by Praveen RewarHey! Can I work on this Issue?
The PR #785 was created against this repo and I asked @Jenil1905 to create it in the https://github.com/carvel-dev/release-scripts repository. Was not sure if the answer was "no, I will not do it" or "no, I do not mind creating the PR in that repo" 😄
Nevertheless I am open to any of you 2 to create a PR in that repository and I will review it.carvel-dev/release-scripts#44
Does this work? This is my first time contributing in a real project and I will be very interested in knowing my mistakes(which I am sure are many).can i work on this issue
Can you assign this issue , i will try my best to fix this
Given that @Watrdguy can yll instead review carvel-dev/release-scripts#44 and validate it to make sure it works?
can i work on this issue
Yes do not forget that the change needs to happen in the other repository
Hi, I checked the current
install.sh.txttemplate. It looks like it’s already POSIX-compatible and supports sha1sum / sha256sum fallbacks. Please let me know if there’s any other portability issue I could help with.I think that the main issue was that we had sha256sum there but if the way it works not is good I am ok closing this issue
can i wrk on this project
The current install script has bogus requirements of bash and shasum. Because of the way it is written the script runs fine with sh and sha1sum.
This should be fixed because some environments, for example the Alpine Linux docker image, do not have them.
If you are checking for curl and wget, you should also check for sha1sum (or better yet use sha256sum).
The hard requirement on bash is just unneeded.
The requirements can easily be bypassed by just faking the environment, proving my point: