Skip to content

feat: add custom scopes support for applications - #239

Closed
monkey92t wants to merge 1 commit into
casdoor:masterfrom
monkey92t:fix_custom_scopes
Closed

feat: add custom scopes support for applications#239
monkey92t wants to merge 1 commit into
casdoor:masterfrom
monkey92t:fix_custom_scopes

Conversation

@monkey92t

Copy link
Copy Markdown

@CLAassistant

CLAassistant commented May 16, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@monkey92t

Copy link
Copy Markdown
Author

The bugs found in the test seem to have nothing to do with ApplicationCustomScopes.

@monkey92t

Copy link
Copy Markdown
Author

@hsluoyz merged?

@hsluoyz

hsluoyz commented Jun 1, 2026

Copy link
Copy Markdown
Member

@monkey92t fix CI errors:

image

@monkey92t

Copy link
Copy Markdown
Author

@hsluoyz

I don't think this issue is related to the current PR, and it seems there is something wrong with this CI error itself. I checked the token_test.go test file:

	// Delete the object
	_, err = DeleteToken(token)
	if err != nil {
		t.Fatalf("Failed to delete object: %v", err)
	}

	// Validate the deletion
	deletedToken, err := GetToken(name)
	if err != nil || deletedToken != nil {
		t.Fatalf("Failed to delete object, it's still retrievable")
	}

and printed the error message: err.Error() = The token: admin/Token_489387 does not exist.

Looking at the test code, it deletes a token and then attempts to retrieve it. Casdoor correctly returns the error token xxx does not exist, and this error response itself is valid. It seems we need to adjust this test code instead.

@hsluoyz hsluoyz closed this Aug 6, 2026
@hsluoyz hsluoyz reopened this Aug 6, 2026
@hsluoyz

hsluoyz commented Aug 12, 2026

Copy link
Copy Markdown
Member

replaced by: 35af3bc

@hsluoyz hsluoyz closed this Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants