feat: add custom scopes support for applications - #239
Closed
monkey92t wants to merge 1 commit into
Closed
Conversation
Author
|
The bugs found in the test seem to have nothing to do with ApplicationCustomScopes. |
Author
|
@hsluoyz merged? |
Member
|
@monkey92t fix CI errors:
|
Author
|
I don't think this issue is related to the current PR, and it seems there is something wrong with this CI error itself. I checked the token_test.go test file: // Delete the object
_, err = DeleteToken(token)
if err != nil {
t.Fatalf("Failed to delete object: %v", err)
}
// Validate the deletion
deletedToken, err := GetToken(name)
if err != nil || deletedToken != nil {
t.Fatalf("Failed to delete object, it's still retrievable")
}and printed the error message: Looking at the test code, it deletes a token and then attempts to retrieve it. Casdoor correctly returns the error |
Member
|
replaced by: 35af3bc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

see: casdoor/casdoor#5140