chore: simplify shadowJar config. #232
Draft
+7
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autonomousapps
commented
May 7, 2025
Comment on lines
-83
to
86
|
|
||
| tasks.withType<JavaCompile> { | ||
| sourceCompatibility = JavaVersion.VERSION_11.toString() | ||
| targetCompatibility = JavaVersion.VERSION_11.toString() | ||
| configure<JavaPluginExtension> { | ||
| sourceCompatibility = JavaVersion.VERSION_11 | ||
| targetCompatibility = JavaVersion.VERSION_11 | ||
| } |
There was a problem hiding this comment.
The change is to configure the java {} extension instead, which expresses the intent better and also works against the latest pre-release version of Shadow (9.0.0-beta13).
autonomousapps
commented
May 7, 2025
There was a problem hiding this comment.
With this change, we ensure that we always relocate everything and don't have to maintain a fragile list.
Note I also tested this with the latest pre-release version of Shadow and it works even better, though with a tiny API change.
autonomousapps
force-pushed
the
trobalik.cleanup
branch
from
422865d to
4993c83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from #231.
Note this requires a beta version of Shadow, so we probably can't land it yet. Pushed anyway as a proof of concept. We can return to this when Shadow 9 has a release version.