Add composable wallet trait system #1581
Draft
+1,542
−438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crodas
force-pushed
the
feature/wallet-trait
branch
from
497aa6d to
85ffb8b
Compare
crates/cdk/src/wallet/traits.rs
Outdated
|
|
||
| #[cfg_attr(target_arch = "wasm32", async_trait::async_trait(?Send))] | ||
| #[cfg_attr(not(target_arch = "wasm32"), async_trait::async_trait)] | ||
| impl WalletMintInfo for Wallet { |
Collaborator
There was a problem hiding this comment.
Do we see a use case where we would want multiple traits to implement only part of the api? I don't think I see one and one trait would be simpler.
Collaborator
There was a problem hiding this comment.
i don't see how this change addresses the comment of 1 wallet trait vs the multiple it still has multiple. To be clear I not strongly against having multiple traits if there is a reason for it, just one trait would be simpler but if others see a use case for the multiple I'm okay with that.
crodas
force-pushed
the
feature/wallet-trait
branch
2 times, most recently
from
1a2fd1f to
b535f81
Compare
crodas
force-pushed
the
feature/wallet-trait
branch
from
b535f81 to
84528dd
Compare
crodas
force-pushed
the
feature/wallet-trait
branch
3 times, most recently
from
3dbcb17 to
60280ad
Compare
Add a new `Wallet` trait in cdk-common that provides a comprehensive interface for all wallet operations with associated types. This enables trait-based polymorphism for different wallet implementations, better FFI support, and cleaner separation between interface and implementation. The `mint_quote` method now accepts a `PaymentMethod` parameter and routes to Bolt11, Bolt12, or Custom payment backends — matching the existing `melt_quote` pattern. Key changes: - Define `Wallet` trait in cdk-common with associated types for Amount, Proofs, MintQuote, MeltQuote, Token, PaymentMethod, etc. - Implement the trait for the concrete `Wallet` struct in cdk - Route `mint_quote` by PaymentMethod (Bolt11/Bolt12/Custom) - Add wallet_trait.rs to cdk-ffi for FFI support - Update CLI, multi-mint wallet, examples, and integration tests - Refactor balance, keyset, and issue modules to use the trait
crodas
force-pushed
the
feature/wallet-trait
branch
from
60280ad to
ee94ebb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce a modular trait system for wallet implementations that enables flexible composition of wallet capabilities. This allows different wallet implementations to share a common interface while supporting selective trait implementation.
The trait hierarchy consists of:
Implements all traits for both cdk::Wallet and cdk-ffi::Wallet, enabling generic code that works with any wallet implementation.
Notes to the reviewers
Suggested CHANGELOG Updates
CHANGED
ADDED
REMOVED
FIXED
Checklist
just final-checkbefore committing