Add oldest data (1991-1995) back to FERC Form 2 archiver - #1284
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1284 +/- ##
=======================================
- Coverage 60.0% 59.9% -0.2%
=======================================
Files 67 67
Lines 3411 3430 +19
=======================================
+ Hits 2049 2056 +7
- Misses 1362 1374 +12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
zschira
left a comment
There was a problem hiding this comment.
Looks good! I had just been meaning to do a test run locally before approving, which I've done now and seems to be working fine
|
@zschira any opinions about this?
|
I think it would make sense to add in for the DBF data since that is a meaningful distinction there, but since XBRL data isn't split into multiple partitions like this, it's probably fine to leave out there. |
Overview
Closes #1259
What problem does this address?
What did you change in this PR?
Question for reviewer
parts = allpartition back for newer DBF and XBRL data?Testing
How did you make sure this worked? How can a reviewer verify this?
Run the archiver and verify the oldest data is not deleted: https://github.com/catalyst-cooperative/pudl-archiver/actions/runs/32282792533
To-do list