Remove the externallib dependency

[wo14580]

Since the version of Moodle 4.2, the unit tests were broken because of the lib/externallib.php. It imposed to isolate the unit tests.
Instead of adding those following annotations as mentioned:

• @runInSeparateProcess
• @runTestsInSeparateProcesses.

I preferred removing the lib/externallib.php dependency.This library will be deprecated soon based on this ticket:
https://tracker.moodle.org/browse/MDL-76583.

Now the unit tests are working correctly.
And we did some manuals tests in our environment and it works correctly.

Cette version de code n'est pas compatible avec les versions avant Moodle 4.2

[dmitriim]

Hi @wo14580

Thanks for looking at this. Your code looks good. However, it seems like we can try to apply a bit more solid approach:

1. Get rid of externallib.php completely and refactor it out to a namespaced class. Example https://github.com/catalyst/moodle-tool_dynamic_cohorts/blob/MOODLE_401_STABLE/classes/external/rule_conditions.php
2. Having (1) we need to update https://github.com/catalyst/moodle-auth_userkey/blob/MOODLE_33PLUS/db/services.php and point auth_userkey_request_login_url to a new class.
3. Move externallib_test.php to match a new class localtion and name space.
4. Update https://github.com/catalyst/moodle-auth_userkey/blob/MOODLE_33PLUS/version.php#L32 so CI runs tests against Moodle 4.2
5. Bump a plugin version.

Unfortunately, we won't be able to remove require_once($CFG->dirroot . '/lib/externallib.php'); at this stage as it's required for older versions, unless we want to spin a new branch. But as long as we can easily keep the branch backwards compatible, I'd prefer to keep it all in one branch. (We will remove this dependency as soon as we get a new branch out. Like 4.4+ or something.)

Hopefully it's not too many changes and thanks again for your contribution. Really appreciate it.

[wo14580]

Hi @dmitriim,
Thank you for your feedback and analyse.
I didn't have time to go deeper when I worked on it but I agree with you.

I'll try to work on these remarks when I have some free time.

Do you have an action plan for future versions in order to be aligned with the new versions of Moodle ?

Thank you and have a nice day.

[dmitriim]

Hi @wo14580
I don't think we have clients using this plugin who's moving to the latest version any time soon. So at this stage it all depends on a community. I'm happy to code review and etc.