Skip to content

Set expirationtime to default if it is not saved during install #530 #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: MOODLE_310_STABLE
Choose a base branch
from
Open

Set expirationtime to default if it is not saved during install #530 #531

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions settings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,10 @@
new lang_string('settings:presignedurl:enablepresignedurls', 'tool_objectfs'),
new lang_string('settings:presignedurl:enablepresignedurls_help', 'tool_objectfs'), ''));

if ($PAGE->pagetype !== 'admin-upgradesettings' && get_config('tool_objectfs', 'expirationtime') === false) {
// In case expirationtime is empty after installation, set it to default to prevent warnings.
set_config('expirationtime', 2 * HOURSECS, 'tool_objectfs');
}
$settings->add(new admin_setting_configduration('tool_objectfs/expirationtime',
new lang_string('settings:presignedurl:expirationtime', 'tool_objectfs'),
new lang_string('settings:presignedurl:expirationtime_help', 'tool_objectfs'), 2 * HOURSECS, HOURSECS));
Expand Down