Skip to content

Issue #633: Move preferexternal setting #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: MOODLE_310_STABLE
Choose a base branch
from
Open

Issue #633: Move preferexternal setting #641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lang/en/tool_objectfs.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,6 @@
$string['settings:permissioncheckpassed'] = 'Permissions check passed.';
$string['settings:handlernotset'] = '$CFG->alternative_file_system_class is not set, the file system will not be able to read from object storage. Background tasks can still function.';

$string['settings:testingheader'] = 'Test Settings';
$string['settings:testingdescr'] = 'This setting is mainly for testing purposes and introduces overhead to check the location.';

$string['settings:error:numeric'] = 'Please enter a number which is greater than or equal 0.';
Expand Down
9 changes: 3 additions & 6 deletions settings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,9 @@
new lang_string('settings:tokenexpirywarnperiod', 'tool_objectfs'),
'', 60 * DAYSECS, DAYSECS));

$settings->add(new admin_setting_configcheckbox('tool_objectfs/preferexternal',
new lang_string('settings:preferexternal', 'tool_objectfs'), '', ''));

$settings->add(new admin_setting_heading('tool_objectfs/filetransfersettings',
new lang_string('settings:filetransferheader', 'tool_objectfs'), ''));

Expand Down Expand Up @@ -247,10 +250,4 @@
}
}
}

$settings->add(new admin_setting_heading('tool_objectfs/testsettings',
Copy link
Contributor

@brendanheywood brendanheywood Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this lang string no longer used now?

Copy link
Contributor Author

@petersistrom petersistrom Oct 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes it is no longer used, updated to remove the lang string

new lang_string('settings:testingheader', 'tool_objectfs'), ''));

$settings->add(new admin_setting_configcheckbox('tool_objectfs/preferexternal',
new lang_string('settings:preferexternal', 'tool_objectfs'), '', ''));
}
Loading