feat: tag skill requests with X-Scribo-Surface - #20
Merged
Conversation
Send `X-Scribo-Surface: skill` on every request from the shared `scribo_request` helper so the Scribo API attributes invoices created through this skill to the `skill` surface in PostHog's cross-surface activation funnel (broken down by `surface`). Additive header; the API only reads it on the create path. Pairs with the core-api change in causa-prima. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Send
X-Scribo-Surface: skillfrom the sharedscribo_requesthelper (skills/scribo/scripts/_common.sh) so the Scribo API attributes invoices created through this skill to theskillsurface in PostHog's cross-surface activation funnel (broken down bysurface).Why
The skill calls the public API the same way a raw API client does, so without this header skill-driven invoices fold into
surface: api. This one line lets us track the skill as its own surface.Notes
causa-prima(which readsx-scribo-surfaceand emits the funnel events). Merge that first; then bump theclient/scribo-skillsubmodule there to this commit.skills/scribo/tests/smoke.sh, 11 checks) +bash -npass.🤖 Generated with Claude Code