Attempt pandas na fix#157
Draft
wagnerlmichael wants to merge 10 commits into
Draft
Conversation
Co-authored-by: Jean Cochrane <jeancochrane@users.noreply.github.com>
Co-authored-by: Jean Cochrane <jeancochrane@users.noreply.github.com>
Member
|
I'm definitely interested in getting to the bottom of this, but in the meantime, I noticed that this behavior changed due to the fact that our uv installation step is ignoring the lockfile and installing a new major version of pandas. This PR should fix the issue faster: #158 |
Member
|
@wagnerlmichael Do you think we'll pick this work back up, or should we close this due to #158 resolving the immediate problem? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential solution:
When a date is missing, pandas represents it as NaT ("Not a Time"). The if value is supposed to catch
missing values and skip formatting, but NaT is truthy in Python. So the code calls .strftime() on NaT and errors out.
This bring in a bigger question about why are are missing
["final_model_run_date"]in the first place, which needs further investigation. Perhaps it is a natural part of the workflow for ineligible PINs?