Skip to content

Attempt pandas na fix#157

Draft
wagnerlmichael wants to merge 10 commits into
mainfrom
attempt-pandas-NA-fix
Draft

Attempt pandas na fix#157
wagnerlmichael wants to merge 10 commits into
mainfrom
attempt-pandas-NA-fix

Conversation

@wagnerlmichael
Copy link
Copy Markdown
Member

@wagnerlmichael wagnerlmichael commented Mar 20, 2026

Potential solution:

When a date is missing, pandas represents it as NaT ("Not a Time"). The if value is supposed to catch
missing values and skip formatting, but NaT is truthy in Python. So the code calls .strftime() on NaT and errors out.

This bring in a bigger question about why are are missing ["final_model_run_date"] in the first place, which needs further investigation. Perhaps it is a natural part of the workflow for ineligible PINs?

@jeancochrane
Copy link
Copy Markdown
Member

I'm definitely interested in getting to the bottom of this, but in the meantime, I noticed that this behavior changed due to the fact that our uv installation step is ignoring the lockfile and installing a new major version of pandas. This PR should fix the issue faster: #158

@jeancochrane
Copy link
Copy Markdown
Member

@wagnerlmichael Do you think we'll pick this work back up, or should we close this due to #158 resolving the immediate problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants