Master #2
Merged
Master #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ummaries, and run contrast curve code automatically (arjunsavel#123) * Update add_dark_exp.py When using csv files for logs, save version with darks to a new file (marked by "_with_darks.csv") so that darks are not appended repeatedly when the pipeline is rerun. * Update create_config.py Set default reduction method using bracket notation instead of dot notation because the column isn't actually added to the data frame when using dot notation. * Update drivers.py Check if specified reduction directory exists and create it if needed. * Update drivers.py Corrected description of reddir. * Update image.py Share original filenames with plot_array so that the shift1_cube.png files can be annotated with filenames. * Update image.py If ShARCS dataset contains BrG-2.16 data and no corresponding flat, use the Ks flat instead. * Update plotting.py Label each subpanel with filename or star name. Add new functionality for plotting reduced images of all stars observed on a single night. * Update sky.py For ShARCS, if no BrG-2.16 flat exists, use Ks flat for reducing BrG-2.16 data. Also removed leftover stray comments. * Update darks.py Removed previously commented out text changing head.update to head.set. * Update plotting.py Corrected typo (missing = in equality check). * Update plotting.py Corrected typo (missing : before if/then statement) * Update add_dark_exp.py Changed literal eval to avoid issues when filenames have leading zeros. * Update drivers.py Added ability to save time by using existing darks, flats, and skies. * Update plotting.py Added if statement to tell the code when to use the "all_stars" version of the plot. * Update plotting.py Added snames=None to ensure that all plotting routines are compatible with the addition of plot_all_stars * Update plotting.py Corrected typos in plot_all_stars. * Update contrast.py Truncate error array to the inner 10" so that lim_arc_lengths, delta_mags, and lim_stds are all the same length. * Update drivers.py correct typo in comments (afrer --> after) * integrate contrast curves into reduction pipeline Automatically run contrast curve code for each star and save plots and csv files showing contrast as a function of angular separation. * Update contrast.py fixed typo in generation of lim_stds * improved contrast curve plotting Flipped y-axis to show brighter objects at top. * Generate nightly summary plots when running drivers.py Produce grid of all images and plot showing all contrast curves. * image.py: added a space added a space to improve readability * Added new module to produce nightly summaries Produce grid showing reduced images for all stars observed and plot showing all contrast curves. * improved flat plotting When plotted in a grid, flats are now shown with a narrower, adaptive color scaling range and labeled by file name. * Added option to run contrast curve code quietly. When run with verbose=False, warning messages from concur are suppressed to avoid messing up the progress bars. * Update utils.py Cast header['CRPIX1'] and header['CRPIX2'] as floats to prevent errors that occur when they are read in as integers. * streamlining & debuggin contrast code * routine to analyze a full night of data * Fixed writing short exposure times Now adds 1 decimal point after exposure times rather than zero. This corrects issue for non-integer exposure times like 1.5 s and 4.5 s. * Check that values in config file match values in fits headers. Code now checks the fits headers of all files included in the config file to make sure that the numbers match. * Adds ability to use nodded skies Added ability to reduce data by nodding to acquire skies rather than using a dither pattern in which the target star is always in the image. Co-authored-by: Arjun Savel <[email protected]>
Don't run darks, flats, and sky drivers again after registering images.
Don't print to screen unless VERBOSE is set. Allow all types of flats to match (e.g., sky flats, dome flats, flats) and improve matching of images taken in J+Ch4-1.2 by allowing different filter capitalization and whitespace in the logsheet.
Return configuration file when user requests to skip data reduction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: