Skip to content

feat: allow setting gcds-nav-links as external#1257

Open
radmorecameron wants to merge 2 commits into
cds-snc:mainfrom
radmorecameron:allow-settings-gcds-nav-links-as-external
Open

feat: allow setting gcds-nav-links as external#1257
radmorecameron wants to merge 2 commits into
cds-snc:mainfrom
radmorecameron:allow-settings-gcds-nav-links-as-external

Conversation

@radmorecameron

Copy link
Copy Markdown
Contributor

📝 Summary | Résumé

This PR allows setting gcds-nav-links as external (it will open in a new tab and shows the same icon, similar to how the gcds-link functions)

This change is motivated by the need that people might need to navigate to a help/instructions page while in a wizard and wouldn't want to lose their progress.

top nav where the contact us link is an external link with an icon

🧩 Related Issues | Cartes liées

🧪 Test instructions | Instructions pour tester la modification

  1. checkout this branch
  2. build web npm run build:web
  3. build storybook npm run build-storybook
  4. run storybook npm run start-storybook
  5. go to nav-link storybook
  6. look at external example

✍️ Author checklist | Liste de vérification de l'auteur

Choose one:

  • This PR introduces a minor change (use feat:)

Breaking changes flag:

  • This PR does not break existing functionality. I have completely tested the functionality of these changes.
  • This PR does not introduce any changes to component names, properties, values, or behaviour.

Ready for review: (all items must be checked)

  • I have tested the English and French versions of the changes, and can verify that all content is accurate and properly displayed in both languages.
  • I have tested these changes on mobile viewports.
  • I have tested these changes across multiple supported browsers.
  • I have checked accessiblity and ensured all accessiblity tests pass.
  • I have added tests for added functionality or changed existing tests, as needed.
  • Visual or content changes remain aligned with design tokens and component API standards.
  • Test instructions are clear and reproducible.

🧐 Reviewer checklist | Liste de vérification du réviseur

Developer checklist

For PRs that are complex, in lieu of a simple approval or an "LGTM" ✅, paste the following info with your approval:

  • I have tested the changes and functionality using the test instructions.
  • I have confirmed test coverage is adequate.
  • I have reviewed the code for clarity, maintainability and potential issues.

Design checklist (if needed)

For designers, include the following info with your approval:

  • I have tested the changes and functionality using the test instructions.
  • The changes meet design expectations and align with the design system.
  • Any design inconsistencies have been raised on slack or tracked via an issue.

Content checklist (if needed)

For content, include the following info with your approval:

  • I understand the context and intent of the content changes.
  • I have reviewed all content for clarity, readability, and tone.
  • I have reviewed English and French content for accuracy and parity.

⚠️ Impact/Risks | Risques

Optional: Use this section to highlight any potential implcations, risks or important notes for reviewers or maintainers, i.e. breaking changes, performance implications, dependency updates, etc.
Highlight any deprecation notices here

@radmorecameron radmorecameron requested a review from a team as a code owner May 14, 2026 21:43
@radmorecameron radmorecameron force-pushed the allow-settings-gcds-nav-links-as-external branch from 7efed60 to 7c00042 Compare May 21, 2026 21:05

@ethanWallace ethanWallace left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thank you for the contribution! We will forward this on to our design team to see if we can get this reflected in our design files before merging/releasing.

  • I have tested the changes and functionality using the test instructions.
  • I have confirmed test coverage is adequate.
  • I have reviewed the code for clarity, maintainability and potential issues.

@daine

daine commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

Thanks @radmorecameron for this PR! The rest of the team is taking a look at it this sprint, we'll be needing our design team to take a look at it as well and provide their approval. Appreciate your work and your patience!

@daine daine left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @radmorecameron although the code looks good, we're considering potentially other approaches and solutions for the original feature request. Someone from our team will reach out to you in the linked issue #1256 . Thank you for the contribution, and we appreciate your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: ability to have nav-links open in a new tab

3 participants