feat: allow setting gcds-nav-links as external#1257
Conversation
7efed60 to
7c00042
Compare
ethanWallace
left a comment
There was a problem hiding this comment.
This is great! Thank you for the contribution! We will forward this on to our design team to see if we can get this reflected in our design files before merging/releasing.
- I have tested the changes and functionality using the test instructions.
- I have confirmed test coverage is adequate.
- I have reviewed the code for clarity, maintainability and potential issues.
|
Thanks @radmorecameron for this PR! The rest of the team is taking a look at it this sprint, we'll be needing our design team to take a look at it as well and provide their approval. Appreciate your work and your patience! |
daine
left a comment
There was a problem hiding this comment.
Hi @radmorecameron although the code looks good, we're considering potentially other approaches and solutions for the original feature request. Someone from our team will reach out to you in the linked issue #1256 . Thank you for the contribution, and we appreciate your patience!
📝 Summary | Résumé
This PR allows setting gcds-nav-links as external (it will open in a new tab and shows the same icon, similar to how the
gcds-linkfunctions)This change is motivated by the need that people might need to navigate to a help/instructions page while in a wizard and wouldn't want to lose their progress.
🧩 Related Issues | Cartes liées
🧪 Test instructions | Instructions pour tester la modification
npm run build:webnpm run build-storybooknpm run start-storybook✍️ Author checklist | Liste de vérification de l'auteur
Choose one:
feat:)Breaking changes flag:
Ready for review: (all items must be checked)
🧐 Reviewer checklist | Liste de vérification du réviseur
Developer checklist
For PRs that are complex, in lieu of a simple approval or an "LGTM" ✅, paste the following info with your approval:
Design checklist (if needed)
For designers, include the following info with your approval:
Content checklist (if needed)
For content, include the following info with your approval:
Optional: Use this section to highlight any potential implcations, risks or important notes for reviewers or maintainers, i.e. breaking changes, performance implications, dependency updates, etc.
Highlight any deprecation notices here