Skip to content

Scope webauthn credentials lookup in webauthn_two_factor_authenticatable strategy to the user that initiated sign in#90

Merged
santiagorodriguez96 merged 2 commits intomasterfrom
sr--scope-credentials-in-2fa
Jan 12, 2026
Merged

Scope webauthn credentials lookup in webauthn_two_factor_authenticatable strategy to the user that initiated sign in#90
santiagorodriguez96 merged 2 commits intomasterfrom
sr--scope-credentials-in-2fa

Conversation

@santiagorodriguez96
Copy link
Collaborator

Fixes #88.

@santiagorodriguez96
Copy link
Collaborator Author

I really think we need to add tests (model or request) for the different edge cases on our strategies. I'll take care of that as part of a separate PR.

Copy link
Member

@nicolastemciuc nicolastemciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@santiagorodriguez96 santiagorodriguez96 merged commit 3788f04 into master Jan 12, 2026
39 of 40 checks passed
@santiagorodriguez96 santiagorodriguez96 deleted the sr--scope-credentials-in-2fa branch January 12, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scope webauthn credentials lookup in webauthn_two_factor_authenticatable strategy to the user that initiated sign in

2 participants