Add request specs for authentication flows #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ations` offenses
| challenge = WebAuthn.configuration.encoder.encode(SecureRandom.random_bytes(32)) | ||
| raw_credential = fake_client.create(challenge: challenge) | ||
| webauthn_credential = WebAuthn::Credential.from_create(raw_credential) | ||
| webauthn_credential.verify(challenge) |
Member
There was a problem hiding this comment.
Does it really make sense to verify the credential if it's just for test setup?
Collaborator
Author
There was a problem hiding this comment.
Yeah my bad. It's not needed at all 👍
|
|
||
| raw_credential = fake_client.create(challenge: creation_options.challenge) | ||
| webauthn_credential = WebAuthn::Credential.from_create(raw_credential) | ||
| webauthn_credential.verify(creation_options.challenge) |
| end | ||
| end | ||
|
|
||
| describe "sign-in without 2FA" do |
Member
There was a problem hiding this comment.
Should we maybe reflect something like "sign in with a user with 2FA disabled"
Comment on lines
+1
to
+20
| # This configuration was generated by | ||
| # `rubocop --auto-gen-config` | ||
| # on 2026-01-02 20:36:46 UTC using RuboCop version 1.79.1. | ||
| # The point is for the user to remove these configuration records | ||
| # one by one as the offenses are removed from the code base. | ||
| # Note that changes in the inspected code, or installation of new | ||
| # versions of RuboCop, may require this file to be generated again. | ||
|
|
||
| # Offense count: 1 | ||
| # Configuration parameters: Max, CountAsOne. | ||
| RSpec/ExampleLength: | ||
| Exclude: | ||
| - 'spec/requests/devise/two_factor_authentication_spec.rb' | ||
|
|
||
| # Offense count: 9 | ||
| # Configuration parameters: Max. | ||
| RSpec/MultipleExpectations: | ||
| Exclude: | ||
| - 'spec/requests/devise/passkey_authentication_spec.rb' | ||
| - 'spec/requests/devise/two_factor_authentication_spec.rb' |
Member
There was a problem hiding this comment.
Should we disable these cops instead of creating a rubocop_todo?
Collaborator
Author
There was a problem hiding this comment.
I was planning on disabling them after this PR so that's why I added them to this file
nicolastemciuc
approved these changes
Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Right now we don't have specific tests for our strategies apart from our system tests, which because of its nature don't really cover all the edge cases. This is leading to weird behaviors such as the one described in #88.
The goal of this PR is to add request specs to test the different authentication flows, which the different edge case, in order to try to test all the strategies and how they work together.
This could in term allow us to stop relying too much in our system tests which have been behaving a little bit flaky.
Details
This PR adds two request specs:
spec/requests/devise/passkey_authentication_spec.rb(for testing authentication with passkeys) andspec/requests/devise/two_factor_authentication_spec.rb(for testing authentication with email/password and 2FA).