Remove celeritas includes from downstream and more IWYU#2340
Merged
sethrj merged 10 commits intoceleritas-project:developfrom Mar 30, 2026
Merged
Remove celeritas includes from downstream and more IWYU#2340sethrj merged 10 commits intoceleritas-project:developfrom
sethrj merged 10 commits intoceleritas-project:developfrom
Conversation
sethrj
added
core
sethrj
requested review from
amandalund,
drbenmorgan,
elliottbiondo and
stognini
as code owners
stognini
reviewed
Mar 30, 2026
amandalund
approved these changes
Mar 30, 2026
stognini
approved these changes
Mar 30, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2340 +/- ##
===========================================
+ Coverage 87.15% 87.19% +0.04%
===========================================
Files 1373 1373
Lines 43599 43581 -18
Branches 13345 13341 -4
===========================================
+ Hits 37997 37999 +2
+ Misses 4383 4364 -19
+ Partials 1219 1218 -1
🚀 New features to boost your workflow:
|
Test summary 5 975 files 9 632 suites 8m 28s ⏱️ Results for commit 3f2d542. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes some "unintentional" includes of celeritas in upstream code, and removes some of the Repr code to prevent a bunch of classes from propagating into every single unit test.