Skip to content

Use std::size_t for Array#2341

Merged
sethrj merged 4 commits intoceleritas-project:developfrom
sethrj:sizet-array
Mar 30, 2026
Merged

Use std::size_t for Array#2341
sethrj merged 4 commits intoceleritas-project:developfrom
sethrj:sizet-array

Conversation

@sethrj
Copy link
Copy Markdown
Member

@sethrj sethrj commented Mar 30, 2026

Using celeritas::size_type (which is 32-bit when CUDA is enabled) causes weird inconsistencies with Span. We do not want to change Span to use size_type, because Span<byte> underpins our device allocator. This should have no adverse effects and should improve compatibility with other libraries.

@sethrj sethrj requested a review from pcanal March 30, 2026 14:02
@sethrj sethrj requested a review from elliottbiondo as a code owner March 30, 2026 14:02
@sethrj sethrj added core Software engineering infrastructure (corecel) minor Refactoring or minor internal changes/fixes labels Mar 30, 2026
@sethrj sethrj removed the request for review from elliottbiondo March 30, 2026 14:02
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

❌ Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 87.19%. Comparing base (8874128) to head (9cd2114).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
src/orange/MatrixUtils.cc 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2341      +/-   ##
===========================================
- Coverage    87.20%   87.19%   -0.02%     
===========================================
  Files         1373     1373              
  Lines        43581    43581              
  Branches     13785    13785              
===========================================
- Hits         38005    37999       -6     
- Misses        4535     4537       +2     
- Partials      1041     1045       +4     
Files with missing lines Coverage Δ
src/corecel/cont/Array.hh 100.00% <ø> (ø)
src/corecel/cont/ArrayIO.json.hh 91.66% <ø> (ø)
src/corecel/cont/Span.hh 100.00% <ø> (ø)
src/corecel/data/HyperslabIndexer.hh 100.00% <ø> (ø)
src/corecel/io/Repr.hh 52.43% <ø> (ø)
src/corecel/math/ArrayOperators.hh 100.00% <ø> (ø)
src/corecel/math/ArrayQuantity.hh 96.77% <100.00%> (ø)
src/corecel/math/ArraySoftUnit.hh 100.00% <ø> (ø)
src/corecel/math/ArrayUtils.hh 100.00% <ø> (ø)
src/corecel/math/PolyEvaluator.hh 100.00% <ø> (ø)
... and 8 more

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 30, 2026

Test summary

 5 960 files   9 617 suites   19m 37s ⏱️
 2 242 tests  2 201 ✅  41 💤 0 ❌
33 498 runs  33 371 ✅ 127 💤 0 ❌

Results for commit 9cd2114.

♻️ This comment has been updated with latest results.

Copy link
Copy Markdown
Contributor

@pcanal pcanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@sethrj sethrj merged commit 008ef57 into celeritas-project:develop Mar 30, 2026
77 of 79 checks passed
@sethrj sethrj deleted the sizet-array branch March 30, 2026 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Software engineering infrastructure (corecel) minor Refactoring or minor internal changes/fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants