Simplify collection backend implementation#2351
Open
sethrj wants to merge 10 commits intoceleritas-project:developfrom
Open
Simplify collection backend implementation#2351sethrj wants to merge 10 commits intoceleritas-project:developfrom
sethrj wants to merge 10 commits intoceleritas-project:developfrom
Conversation
Test summary 5 955 files 9 652 suites 19m 26s ⏱️ Results for commit 3e029d0. ♻️ This comment has been updated with latest results. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2351 +/- ##
========================================
Coverage 87.26% 87.26%
========================================
Files 1377 1377
Lines 43836 43826 -10
Branches 13875 13866 -9
========================================
- Hits 38253 38245 -8
+ Misses 4524 4520 -4
- Partials 1059 1061 +2
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes some of the extra templating and redundant traits classes used in collection. It should slightly reduce the amount of object code due to simplified templates, will make debugging easier due to one nested class implementation, and generally should be easier to read.