Test patternal 3 #54
Draft
Test patternal 3 #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalex
commented
Dec 17, 2024
| auto quants = tk.get_quantification_date(1. / 4); | ||
| auto [pos0, q0] = quants[0]; | ||
| REQUIRE(quants.size() == 1); | ||
| REQUIRE(pos0 == -2147483648); |
There was a problem hiding this comment.
Pos is always -2147483648
aalex
force-pushed
the
test-patternal-3
branch
from
6ebb96b to
1d5326c
Compare
Add test_quantification_date Add this-> to make the code easier to read WIP fix errors in test WIP Improve the unit test a lot Improve the unit test Add some doc
aalex
force-pushed
the
test-patternal-3
branch
from
1d5326c to
cc63e6d
Compare
|
fyi the build on main is fixed so this can be rebased to ensure green CI :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.