fix: ShareClassManager and SimplePriceManager - transfer shares underflow#746
Merged
fix: ShareClassManager and SimplePriceManager - transfer shares underflow#746
Conversation
onnovisser
changed the title
wischli
reviewed
Oct 17, 2025
Contributor
wischli
left a comment
wischli
left a comment
There was a problem hiding this comment.
Makes sense to me and seems feasible! Thanks for the fix. Overall, I'd love to see some assertions/tests in e2e in the future, definitely not this PR.
|
|
||
| // When shares are transferred, the issuance in the SCM updates immediately, | ||
| // but in this contract they are tracked separately as transferredIn/Out. | ||
| // Here we get the diff between the old SPM issuance and the new SCM issuance, |
Contributor
There was a problem hiding this comment.
Nit
Suggested change
| // Here we get the diff between the old SPM issuance and the new SCM issuance, | |
| // Here we get the diff between the old SCM issuance and the new SCM issuance, |
Contributor
There was a problem hiding this comment.
This is intentional (Single Price Manager = SPM)
Contributor
Author
There was a problem hiding this comment.
actually clarified that it's the current stale SPM issuance
| assertEq(toIssuance, 200); | ||
| assertEq(fromTransferredOut, 0); | ||
| assertEq(fromTransferredIn, 0); | ||
| assertEq(toTransferredIn, 50); |
Contributor
There was a problem hiding this comment.
Q: IIUC, this is not 0 because we haven't called onUpdate for network 2 yet right?
hieronx
reviewed
Oct 17, 2025
src/core/hub/ShareClassManager.sol
Outdated
| mapping(PoolId => mapping(ShareClassId => Price)) public pricePoolPerShare; | ||
| mapping(PoolId => mapping(ShareClassId => ShareClassMetadata)) public metadata; | ||
| mapping(PoolId => mapping(ShareClassId => mapping(uint16 centrifugeId => uint128))) public issuance; | ||
| mapping(PoolId => mapping(ShareClassId => mapping(uint16 centrifugeId => IssuancePerNetwork))) internal |
Contributor
There was a problem hiding this comment.
Maybe we should make this public. Otherwise there is no way to know the individual sum of issuances and revocations, if it is reverting.
* Benchmarks, add tests * Fix warning
* Add transfer shares test * Cleanup
hieronx
reviewed
Oct 17, 2025
hieronx
reviewed
Oct 17, 2025
hieronx
previously approved these changes
Oct 17, 2025
hieronx
approved these changes
Oct 17, 2025
|
Coverage after merging scm-pending-issuance into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Product requirements
Design notes
TODOs