Add Crosschain Batcher contract#747
Closed
hieronx wants to merge 5 commits intoelectisec-v31-fixesfrom
Closed
Conversation
lemunozm
reviewed
Oct 16, 2025
src/core/hub/Hub.sol
Outdated
|
|
||
| if (what == "gateway") gateway = IGateway(data); | ||
| else if (what == "feeHook") feeHook = IFeeHook(data); | ||
| if (what == "feeHook") feeHook = IFeeHook(data); |
Contributor
There was a problem hiding this comment.
Why don't we allow to set the batcher?
| function withBatch(bytes memory data, uint256 value, address refund) public payable { | ||
| require(value <= msg.value, NotEnoughValueForCallback()); | ||
|
|
||
| gateway.startBatching(); |
Contributor
There was a problem hiding this comment.
The previous isBatching was there to be able to nest batches, which I think it's something cool to allow integrators to have integrators on top, so I would keep it.
| } | ||
|
|
||
| /// @inheritdoc ICrosschainBatcher | ||
| function file(bytes32 what, address data) external auth { |
Contributor
There was a problem hiding this comment.
We need to add root to the deployer, and also allow crosschainBatcher to modify gateway stuff through rely
| isBatching = true; | ||
|
|
||
| function startBatching() external auth { | ||
| _batcher = msg.sender; |
Contributor
There was a problem hiding this comment.
Batcher not needed here, right?
Comment on lines
+266
to
+269
| //---------------------------------------------------------------------------------------------- | ||
| // View methods | ||
| //---------------------------------------------------------------------------------------------- | ||
|
|
Contributor
There was a problem hiding this comment.
Can be removed because there are no view methods?
| using MathLib for *; | ||
| using CastLib for bytes32; | ||
|
|
||
| IGateway public gateway; |
Contributor
There was a problem hiding this comment.
I think this is not needed, or is it there for integrators?
|
|
||
| spoke.crosschainTransferShares{ | ||
| value: gateway.isBatching() ? 0 : msg.value | ||
| value: msgValue() |
Comment on lines
+33
to
+47
| contract MockGateway { | ||
| address internal transient _batcher; | ||
|
|
||
| function startBatching() external { | ||
| _batcher = msg.sender; | ||
| } | ||
|
|
||
| function endBatching(address) external payable { | ||
| _batcher = address(0); | ||
| } | ||
|
|
||
| function batcher() external view returns (address) { | ||
| return _batcher; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
I think you don't need this here right? Only multicall calls withBatch, and it's already tested under BatchedMulticall
test/core/unit/Gateway.t.sol
Outdated
| @@ -912,24 +905,30 @@ contract AttackerIntegrationMock is Test { | |||
| } | |||
|
|
|||
| contract GatewayTestWithBatch is GatewayTest { | |||
Contributor
There was a problem hiding this comment.
This test should be moved to CrosschainBatcher.t.sol
|
Coverage after merging crosschain-batcher into electisec-v31-fixes will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.