Open
Conversation
|
Coverage after merging tests_live-validators into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge strategy
This PR targets
mainfor review purposes. Once approved, only theweekly-validation.ymlCI workflow should be merged intomain. The validator and investment flow test code should be pushed to the separatelive-validatorsbranch, which is pinned to the latest deployed version and runs on a weekly schedule. This keepsmainfree of fork test code that is tightly coupled to the currently deployed contracts. Which was an issue we discussed in the past.Product requirements
ForkTestLiveValidation.sol(1805 lines) with modular validator architecture: One validator per concern, indexer-driven, zero hardcoded addressesVaultRegistryrouting corruption from theunlinkVaultbug (ref)Design notes
BaseValidatorsubclasses, each querying the GraphQL indexer for its data. Adding a validator = one file + one array entry inLiveValidationForkTest.InvestmentFlowExecutorhandles local async, cross-chain async, and cross-chain sync deposit flows with shared redeem logic.weekly-validation.ymlonmainchecks out thelive-validatorsbranch on a Monday schedule via GCP-authed fork tests across 9 networks.Notes