teuthology: add the function of specifying teuthology url #1838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Signed-off-by: Sun Junnan <[email protected]> add the function of specifying teuthology url
kshtsk
reviewed
Feb 27, 2025
| @@ -171,6 +171,7 @@ class TeuthologyConfig(YamlConfig): | |||
| 'koji_task_url': 'https://kojipkgs.fedoraproject.org/work/', | |||
| 'baseurl_template': 'http://{host}/{proj}-{pkg_type}-{dist}-{arch}-{flavor}/{uri}', | |||
| 'use_shaman': True, | |||
| 'teuthology_git_url': 'https://github.com/ceph/teuthology.git', | |||
There was a problem hiding this comment.
This should be None by default, same as ceph_git_url and others.
kshtsk
reviewed
Feb 27, 2025
| @@ -209,6 +210,9 @@ def get_ceph_qa_suite_git_url(self): | |||
| def get_ceph_git_url(self): | |||
| return (self.ceph_git_url or | |||
| self.ceph_git_base_url + 'ceph-ci.git') | |||
| def get_teuthology_git_url(self): | |||
| return self.teuthology_git_url | |||
There was a problem hiding this comment.
this might be the same as the other similar methods, like:
return (self.teuthology_git_url or
self.ceph_git_base_url + 'teuthology.git')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sun Junnan [email protected]
add the function of specifying teuthology url