-
Notifications
You must be signed in to change notification settings - Fork 311
Replace to isinstance #2637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Replace to isinstance #2637
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked at a few files and found various sloppiness errors.
That also indicates that you didn't even try to run the tests.
Please review once again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slightly better, but you still missed two in the list:
intelmq/lib/test.py: elif issubclass(type(msg), message.Message):
intelmq/lib/message.py: if dict_eq and issubclass(type(other), Message):
Have a look at the failing tests. |
This PR brings updates to various files as mentioned in the issue #2636 where
type()
is replaced byisinstance()
Closes #2636