Skip to content

Conversation

@AfonsoMartins26
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Mar 21, 2025

Deploy Preview for cesium-hydrogen-new ready!

Name Link
🔨 Latest commit b3aa702
🔍 Latest deploy log https://app.netlify.com/sites/cesium-hydrogen-new/deploys/67e2204efab2ac0008e86ad0
😎 Deploy Preview https://deploy-preview-161--cesium-hydrogen-new.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AfonsoMartins26 AfonsoMartins26 self-assigned this Mar 21, 2025
@AfonsoMartins26 AfonsoMartins26 marked this pull request as draft March 21, 2025 22:57
@AfonsoMartins26 AfonsoMartins26 marked this pull request as ready for review March 22, 2025 00:19
Copy link
Member

@joaodiaslobo joaodiaslobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very off from the design.
The content should be placed inside a card.
There should be an orange arrow on the right side of the component, to tell the user that they can scroll.
image

See here that the date block changes layout on mobile:

image

Also, put a limit on the amount of events shown.

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Hydrogen - Development Mar 22, 2025
@AfonsoMartins26
Copy link
Contributor Author

AfonsoMartins26 commented Mar 22, 2025

This looks very off from the design.
The content should be placed inside a card.
There should be an orange arrow on the right side of the component, to tell the user that they can scroll.
image

See here that the date block changes layout on mobile:

image

Also, put a limit on the amount of events shown.

Thats the component @gxnca did i just did the cards inside and the text

@gxnca
Copy link
Member

gxnca commented Mar 23, 2025

I believe we should either wrap everything (except the header) on a <section> and use {horizontalPadding}, or use it on each section.
Since @AfonsoMartins26 didn't use those paddings on his section, the LandingSectionCard is stretching.

This is how it looks with the missing Paddings:

imagem

As for the orange arrow, it was decided to exclude it from the design. @diogogmatos suggested to make the cards clickable, redirecting the user to the events page.

I also recommend to use overflows property from LandingSectionCard in order to enable the scroll gradients.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Hydrogen - Development Mar 24, 2025
@github-project-automation github-project-automation bot moved this from Done to In Progress in Hydrogen - Development Mar 24, 2025
Copy link
Member

@joaodiaslobo joaodiaslobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not fetching strings from dictionary, title and description always in Portuguese.

Copy link
Member

@nunom27 nunom27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@diogogmatos diogogmatos merged commit 8ca699b into main Mar 25, 2025
5 checks passed
@diogogmatos diogogmatos deleted the am/landing-events-section branch March 25, 2025 03:27
@github-project-automation github-project-automation bot moved this from In Progress to Done in Hydrogen - Development Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

feat: landing events section

6 participants