ENT-12600: Document and refactor compile-options #1744
Conversation
|
Thank you for submitting a pull request! Maybe @craigcomstock can review this? |
build-scripts/compile-options
Outdated
| # libgcc_s.so is needed before we compile any other dependency | ||
| # on some platforms! |
There was a problem hiding this comment.
| # libgcc_s.so is needed before we compile any other dependency | |
| # on some platforms! | |
| # libgcc_s.so is needed before we compile any other dependencies on some platforms! |
Is it specifically libgcc_s.so or is it the gcc command? Curious.
There was a problem hiding this comment.
No clue. Preexisting comment ;)
build-scripts/compile-options
Outdated
| # Library for managing Extended Attributes (xattrs) on filesystems | ||
| var_append DEPS "libattr" | ||
|
|
||
| # POSIX Access Control Lists (ACLs) on filesystems | ||
| var_append DEPS "libacl" |
There was a problem hiding this comment.
might be interesting to note if (and I think they are) dependencies of apache?
There was a problem hiding this comment.
I can't see them specified as dependencies when building apache. Looks like apache depends on z, ssl, ldap, apr, apr-util, pcre.
build-scripts/compile-options
Outdated
| nova-*-debian-*) | ||
| ROLE=hub | ||
| ;; | ||
| nova-*-opensuse-*) |
There was a problem hiding this comment.
we don't support hub on opensuse.
Signed-off-by: Lars Erik Wik <[email protected]>
We don't really build with something else then lmdb. Hence, we don't need the option to build with something else. Signed-off-by: Lars Erik Wik <[email protected]>
Ticket: ENT-12600 Signed-off-by: Lars Erik Wik <[email protected]>
Ticket: ENT-12600 Signed-off-by: Lars Erik Wik <[email protected]>
Ticket: ENT-12600 Signed-off-by: Lars Erik Wik <[email protected]>
This auto detect role code is weird. It tries to detect whether to build a hub or agent package based on the platform it's being built for. In many places it even decides to build hub packages for platforms where it's not supported. I wonder if life will just go on if I remove it. Signed-off-by: Lars Erik Wik <[email protected]>
|
Build with exotics (no tests) |
| # Embedded DB selection | ||
| EMBEDDED_DB="lmdb" |
There was a problem hiding this comment.
I think we want to keep this option.
There was a problem hiding this comment.
Why? It's not really an option. It's a variable holding a hard coded string. You cannot override it without modifying the script.
It makes it easier to read diffs. Ticket: ENT-12600 Signed-off-by: Lars Erik Wik <[email protected]>
larsewi
force-pushed
the
compile-options
branch
from
d4fc6b8 to
61170dd
Compare
Uh oh!
There was an error while loading. Please reload this page.