Skip to content

ENT-12600: configure: Documented and refactored script #1777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

larsewi
Copy link
Contributor

@larsewi larsewi commented Jun 24, 2025

  • configure: Removed code duplication
  • configure: Reformatted case statements for consistency
  • configure: Remove CODE_COVERAGE build type
  • configure: Fixed shellcheck issues
  • configure: Decrease verbosity of script

Example output:

 ---snip---
configure: debug: running configure on core repo...
configure: debug: running configure on enterprise repo...
configure: debug: running configure on nova repo...
Error: Failed to run: env CFLAGS=-g2 -O1  ./configure --prefix=/var/cfengine --libdir=/var/cfengine/lib --with-workdir=/var/cfengine --sysconfdir=/etc --with-openssl=/var/cfengine --with-pcre2=/var/cfengine --with-librsync=/var/cfengine --with-init-script --with-lmdb=/var/cfengine --without-pthreads-w32 --with-ldap=/var/cfengine --with-libxml2=/var/cfengine --with-libyaml=/var/cfengine --with-librsync=/var/cfengine --with-leech=/var/cfengine --with-libacl=/var/cfengine --without-libvirt --with-libcurl=/var/cfengine --with-postgresql=/var/cfengine --without-mysql --with-cfmod --with-enterprise-api --with-postgresql=/var/cfengine --with-systemd-service --enable-debug
--- Start of Output ---
 ---snip---
configure: error: Cannot find php devel files
--- End of Output (Error Code: 1) ---

@cf-bottom
Copy link

Thanks for submitting a pull request! Maybe @craigcomstock can review this?

@larsewi larsewi marked this pull request as ready for review July 24, 2025 12:04
@larsewi larsewi requested a review from craigcomstock July 24, 2025 12:04
@larsewi larsewi marked this pull request as draft July 25, 2025 11:54
@larsewi larsewi changed the title ENT-12600: configure: Documented script ENT-12600: configure: Documented and refactored script Jul 25, 2025
larsewi added 7 commits July 31, 2025 11:57
The code for adding the correct "configure" feature selection options
(i.e., --with-dep=/path/to/dep/, --without-dep) based on the
dependencies had a lot of repetitive code. I created a for loop for
those that are nearly identical.

Signed-off-by: Lars Erik Wik <[email protected]>
Because we don't use it.

Signed-off-by: Lars Erik Wik <[email protected]>
Ticket: ENT-12600
Signed-off-by: Lars Erik Wik <[email protected]>
Ticket: ENT-12600
Signed-off-by: Lars Erik Wik <[email protected]>
We want word splitting so that the arguments are not interpreted as one
string.

Ticket: ENT-12600
Signed-off-by: Lars Erik Wik <[email protected]>
@larsewi
Copy link
Contributor Author

larsewi commented Aug 4, 2025

Build with no tests
Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants