structure_test: limit regex checks to small non-binary files#267
Open
imjasonh wants to merge 3 commits intochainguard-dev:mainfrom
Open
structure_test: limit regex checks to small non-binary files#267imjasonh wants to merge 3 commits intochainguard-dev:mainfrom
imjasonh wants to merge 3 commits intochainguard-dev:mainfrom
Conversation
Signed-off-by: Jason Hall <jason@chainguard.dev>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds validation to limit regex checks in file structure tests to small, non-binary files. The change prevents regex matching on files larger than 1MB or containing binary data (null bytes), causing faster failure for inappropriate file types.
Key changes:
- Added size limit validation (1MB maximum) for files before regex matching
- Added binary file detection by checking for null bytes in the first 8KB
- Created comprehensive test coverage for both size and binary content validation scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/structure/structure.go | Added size and binary validation logic with 1MB limit constant |
| pkg/structure/structure_test.go | Added comprehensive test cases covering size limits and binary detection |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Jason Hall <jason@chainguard.dev>
Signed-off-by: Jason Hall <jason@chainguard.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fails faster when regex tests are requested on large (>1 MB) or binary files (containing null bytes)