Skip to content

remove 307 from path "/" #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

remove 307 from path "/" #1200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion web/app/src/middleware/home.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ export async function middleware(
// return NextResponse.redirect(loginUrl);
// }
if (url.pathname === '/') {
return NextResponse.redirect(new URL('/welcome', request.url));
// return NextResponse.redirect(new URL('/welcome', request.url));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议添加注释说明为什么使用 rewrite 而不是 redirect，以便其他开发者理解这个设计决策

Suggested change
// return NextResponse.redirect(new URL('/welcome', request.url));
// 使用 rewrite 而不是 redirect 以保持 URL 不变，提供更好的用户体验
return NextResponse.rewrite(new URL('/welcome', request.url));

return NextResponse.rewrite(new URL('/welcome', request.url));
}

// 页面上报
Expand Down