Skip to content

Conversation

@MoralCode
Copy link
Contributor

Description

  • This change is a simple stylistic refactoring change that adjusts how our SQLAlchemy models are defined so that it follows consistent rules

These rules are:

  • additional metadata parameters in models specifying constraints, tablename, or schema) appear at the top of the class definition
  • these metadata definitions should use the simplest syntax available given what they need to do (i.e. if a model only needs a schema set, it can be defined as a plain dict, but if its a schema setting and constraints, it needs to be a tuple with the dict at the end)

This PR is intended to pull this relatively simple improvement out from #3435 to make that PR more easy to review.

Notes for Reviewers

This should be a relatively easy merge

Signed commits

  • Yes, I signed my commits.

@MoralCode MoralCode added the ready Items tested and seeking additional approvals or a merge. Usually for items under active development label Dec 9, 2025
@sgoggins sgoggins requested a review from Ulincsys December 9, 2025 22:32
Copy link
Member

@sgoggins sgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sgoggins sgoggins self-assigned this Dec 9, 2025
@sgoggins sgoggins merged commit 34f5644 into main Dec 9, 2025
15 checks passed
@MoralCode MoralCode deleted the ntdn/consistent-sa-model-setup branch December 10, 2025 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready Items tested and seeking additional approvals or a merge. Usually for items under active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants