Fix: Eliminate redundant full table scans in messages and events collection (phase 1, only events.py)#3479
Open
PredictiveManish wants to merge 3 commits intochaoss:mainfrom
Open
Fix: Eliminate redundant full table scans in messages and events collection (phase 1, only events.py)#3479PredictiveManish wants to merge 3 commits intochaoss:mainfrom
PredictiveManish wants to merge 3 commits intochaoss:mainfrom
Conversation
1 task
MoralCode
reviewed
Dec 18, 2025
Contributor
MoralCode
left a comment
MoralCode
left a comment
There was a problem hiding this comment.
code LGTM! Would like to better understand how this has been tested/whether it still needs testing to confirm it works
Contributor
Author
Actually yes it needs testing to confirm! Will confirm when it's done, facing a little issue in setting up as I have purchased a new device so will share when tested. |
MoralCode
reviewed
Jan 8, 2026
MoralCode
added
the
waiting
Contributor
|
marked waiting due to waiting for testing (also probably needs a rebase) |
Signed-off-by: PredictiveManish <manish.tiwari.09@zohomail.in>
PredictiveManish
force-pushed
the
Map-once
branch
from
b3d0ac6 to
1f128fc
Compare
shlokgilda
previously approved these changes
Jan 9, 2026
Collaborator
shlokgilda
left a comment
shlokgilda
left a comment
There was a problem hiding this comment.
LGTM. Waiting to hear back about the testing status.
Contributor
|
Can you resolve the merge conflicts? |
Signed-off-by: Manish Tiwari <manish.tiwari.09@zohomail.in>
Contributor
Author
Yes, sure! |
MoralCode
changed the title
Contributor
|
Once this has been tested, it can be merged. |
Signed-off-by: Manish Tiwari <manish.tiwari.09@zohomail.in>
PredictiveManish
dismissed stale reviews from sgoggins and shlokgilda
via
ae07921
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
augur/tasks/github/events.pyBuilt
issue_url_to_id_mapandpr_url_to_id_maponce inBulkGithubEventCollection.collect()before the batch loopUpdated
_process_events(),_process_issue_events(), and_process_pr_events()to accept mappings as parametersRemoved redundant
_get_map_from_*()calls from batch processing methodsNotes for Reviewers
This PR fixes (partially) Full table scans on every batch in messages and events collection #3440
Signed commits