Fix #2672: Pass db_session to user delete method #3509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guptapratykshh
force-pushed
the
fix/delete-account-2672
branch
3 times, most recently
from
2c82017 to
a08dd38
Compare
MoralCode
reviewed
Jan 7, 2026
guptapratykshh
force-pushed
the
fix/delete-account-2672
branch
from
ba588f4 to
1e7fa95
Compare
guptapratykshh
force-pushed
the
fix/delete-account-2672
branch
2 times, most recently
from
8df7eb0 to
0cf49f2
Compare
Contributor
Author
|
Reverted all the imports and else block that were removed , please review the PR @MoralCode |
Contributor
|
Code looks good! Just make sure to rebase your changes. Id also be curious how this was tested/get a couple maintainers to give it the thumbs up. Overall looks like this is very close to being able to ship! |
guptapratykshh
force-pushed
the
fix/delete-account-2672
branch
from
0cf49f2 to
51d3688
Compare
Contributor
Author
|
I tested this by checking the code (the User.delete() method needs a session parameter that wasn't being passed) and writing a mock test to verify the fix works correctly. Also the docker build failure is not related to this PR. It is CI issue with the geckodriver download because gitHub API returned null. Rerunning the build should fix it. |
- Pass required db_session parameter to current_user.delete() - Add try-except block for proper exception handling - Store username before deletion for accurate flash message - Add error logging for debugging failed deletions Signed-off-by: Pratyksh Gupta <pratykshgupta9999@gmail.com> Signed-off-by: guptapratykshh <pratykshgupta9999@gmail.com>
guptapratykshh
force-pushed
the
fix/delete-account-2672
branch
from
0a52048 to
4793eaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a critical bug where users attempting to delete their accounts would encounter a 500 Internal Server Error. The root cause was that the user_delete() route handler was calling
current_user.delete()without passing the required session parameter.db_sessionparameter toUser.delete()methodThis PR fixes #2672
Notes for Reviewers
Signed commits