fix(#3519): update tensorflow and dependencies to support python 3.12+ #3534
Conversation
MoralCode
left a comment
MoralCode
left a comment
There was a problem hiding this comment.
Overall this looks great! Id like it to be tested manually as well by some of the other maintainers but This is looking like a great PR! excited that all the automatic tests are passing
I'll try and run the unit tests on it sometime soon too
| "pandas>=1.5.3", | ||
| "partd>=0.3.10", | ||
| "protobuf<3.22", | ||
| "protobuf", |
There was a problem hiding this comment.
whats the current latest version of this? is this going to cause us to get put on a new major version?
Id also be curious why we were maxing out at 3.22 before.
There was a problem hiding this comment.
The latest protobuf version is 6.33.2. However, removing the <3.22 cap allows resolver to choose version 4.25.8, which is compatible with tensorflow 2.17.1. The old cap was probably set because tensorflow 2.15.0 used protobuf 3.20.3. The <3.22 constraint aimed to avoid breaking changes from protobuf 4.x. But newer tensorflow 2.17.1 requires protobuf 4.x+.
There was a problem hiding this comment.
oh wow, thats a lot of details on the version history
There was a problem hiding this comment.
I suspect this may need to be done together with and/or after #3336 - a lot of our dependencies are probably transitive, like this protobuf one
guptapratykshh
force-pushed
the
fix/issue-3519-tensorflow-update
branch
from
2006eb8 to
c0e3f02
Compare
…n 3.12+ Signed-off-by: Pratyksh Gupta <[email protected]>
guptapratykshh
force-pushed
the
fix/issue-3519-tensorflow-update
branch
from
c0e3f02 to
9fb9cba
Compare
|
in this PR, can you also re-enable the 3.12 unit tests so we can make sure they are passing too? |
guptapratykshh
force-pushed
the
fix/issue-3519-tensorflow-update
branch
from
7e92272 to
6397660
Compare
Signed-off-by: guptapratykshh <[email protected]>
guptapratykshh
force-pushed
the
fix/issue-3519-tensorflow-update
branch
from
6397660 to
8435c3e
Compare
2 participants
Description
Installation fails on Python 3.12 and above because the pinned version of TensorFlow (2.15.0) does not provide pre-built wheels for Python 3.12. Additionally, scikit-image (0.19.1) fails to build because it depends on distutils, which was removed in Python 3.12.
Updated project dependencies to support Python 3.12 and above, has been done locally:
This PR fixes #3519
Notes for Reviewers
Signed commits