Skip to content

Conversation

@Sukuna0007Abhi
Copy link
Contributor

@Sukuna0007Abhi Sukuna0007Abhi commented Jan 11, 2026

Summary

This PR addresses issue #3323 by commenting out all working_commits table usage to verify it's no longer needed before permanent removal. This is PR using approach to safely remove legacy code.

Changes Made

All working_commits related code has been commented out with # TESTING: Commented out for issue #3323 markers:

  1. Database Library Functions (lib.py)
  • Commented out get_working_commits_by_repo_id()
  • Commented out remove_working_commits_by_repo_id()
  • Commented out remove_working_commits_by_repo_id_and_hashes()
  1. Facade Tasks (facade_tasks.py)
  • Removed working_commits imports (line 8)
  • Commented out working_commits check in trim_commits_facade_task() (lines 93-97)
  • Commented out cleanup call in analyze_commits_in_parallel() (line 336)
  1. Analyze Commit Worker (analyzecommit.py)
  • Commented out INSERT INTO working_commits statement (line 172)
  1. Utility Methods (utilitymethods.py)
  • Removed working_commits imports and cleanup calls from trim_commits()

Testing Performed

Created and ran validation script that confirmed:

PASS: Database tables exist (both at 0 rows)
PASS: Module imports work without errors
PASS: working_commits functions are properly disabled
PASS: commits table remains accessible

Related

Fixes #3323

Pls review @sgoggins @MoralCode @cdolfi

@MoralCode
Copy link
Contributor

marking as draft since this is mentioned as being a testing PR

@Sukuna0007Abhi
Copy link
Contributor Author

Sukuna0007Abhi commented Jan 12, 2026

I verified it in my end, that all working_commits tables are no more usable.. so I will do some more changes and make it ready for review by today...

@nexpectArpit nexpectArpit force-pushed the test-working-commits-disabled-3323 branch from b8d7304 to b8b8535 Compare January 12, 2026 12:31
@Sukuna0007Abhi Sukuna0007Abhi changed the title Test: Comment out working_commits for verification (#3323) feat: Comment out working_commits for verification (#3323) Jan 12, 2026
@Sukuna0007Abhi Sukuna0007Abhi marked this pull request as ready for review January 12, 2026 12:40
@MoralCode MoralCode marked this pull request as draft January 21, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove potentially legacy working commits call/table

2 participants