Add .gitattributes to enforce LF line endings #3556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes chaoss#3545 Signed-off-by: Sukuna0007Abhi <[email protected]>
MoralCode
reviewed
Jan 11, 2026
Comment on lines
+91
to
+99
| *.exe binary | ||
| *.dll binary | ||
| *.so binary | ||
| *.dylib binary | ||
| *.pyc binary | ||
| *.pyo binary | ||
| *.pyd binary | ||
| *.whl binary | ||
| *.egg binary |
Contributor
There was a problem hiding this comment.
a lot of these (from .exe down) are unlikely to be in the repo since many of them are compiled program outputs and wouldnt be checked into git
Comment on lines
+78
to
+80
| # Binary files - ensure they're not modified | ||
| *.png binary | ||
| *.jpg binary |
Contributor
There was a problem hiding this comment.
does the automatic behavior account for this already? whats the default behavior?
Comment on lines
+30
to
+38
| *.html text eol=lf | ||
| *.htm text eol=lf | ||
| *.css text eol=lf | ||
| *.scss text eol=lf | ||
| *.js text eol=lf | ||
| *.jsx text eol=lf | ||
| *.ts text eol=lf | ||
| *.tsx text eol=lf | ||
| *.vue text eol=lf |
Contributor
There was a problem hiding this comment.
do we need to specify every single file type like this given that we assume things are ttext files in the first line?
MoralCode
added
the
redundant
Collaborator
|
@Sukuna0007Abhi There are a couple of other PRs targeting the same issue (#3561, #3562). Could you all please discuss the best way forward and come up with just one PR and close the rest? You can discuss the optimal way forward in the linked issue #3545. |
This was referenced Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3545
Summary
This PR adds a .gitattributes file to the repository to prevent Windows CRLF line ending issues that can break Python scripts and shell script entrypoints.
Changes
Testing
The .gitattributes file follows GitHub's recommended format for handling line endings. This will prevent Git from automatically converting LF to CRLF on Windows systems, which has been causing issues in WSL and other Windows-based environments.
Related Issues
Resolves #3545
Pls review @sgoggins @MoralCode @cdolfi