Skip to content

fix: cleanup TODO comments in frontend.py (fixes #3574) #3576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Noaman-Akhtar wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: cleanup TODO comments in frontend.py (fixes #3574) #3576

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abe26fc
fix: cleanup TODO comments in frontend.py (fixes #3574)
Noaman-Akhtar Jan 13, 2026
b98d55a
Merge branch 'main' into fix/cleanup-frontend-todos
Noaman-Akhtar Jan 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 0 additions & 42 deletions augur/tasks/frontend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,6 @@ def add_gitlab_repos(user_id, group_name, repo_urls):
if existing_repo.repo_group_id != repo_group_id:
update_existing_repos_repo_group_id(session, existing_repo.repo_id, repo_group_id)

# TODO: add logic to update the existing records repo_group_id if it isn't equal to the existing record
add_existing_repo_to_group(logger, session, group_id, existing_repo.repo_id)
continue

Expand Down Expand Up @@ -150,7 +149,6 @@ def get_org_repo_data(orgs, session):

return repo_data

# TODO: Do we need to check if the repo already exists in the user group?
def add_new_github_repos(repo_data, group_id, session, logger):

# get data for repos to determine type, src id, and if they exist
Expand Down Expand Up @@ -198,7 +196,6 @@ def divide_list_into_chunks(data, size):
yield data[i:i + size]


# TODO: Make it only get like 100 at a time
Copy link
Collaborator

@shlokgilda shlokgilda Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Noaman-Akhtar Where was this implemented?

Copy link
Contributor

@guptapratykshh guptapratykshh Jan 14, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is implemented in the function - add_github_orgs_and_repos on line 59

Copy link
Contributor Author

@Noaman-Akhtar Noaman-Akhtar Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guptapratykshh Yes

def get_github_repos_data(repo_data, session, logger):

repo_urls = [x[0] for x in repo_data]
Expand Down Expand Up @@ -364,42 +361,3 @@ def update_existing_repos_repo_group_id(session, repo_id, new_repo_group_id):
# invalid_urls.append(url)

# return valid_orgs, valid_repos, invalid_urls





# TODO: Change to github specific
# @celery.task
# def add_repo(user_id, group_name, repo_url):

# logger = logging.getLogger(add_org.__name__)

# with GithubTaskSession(logger) as session:
# result = UserRepo.add_github_repo(session, repo_url, user_id, group_name)

# print(repo_url, result)


# # TODO: Change to github specific
# @celery.task
# def add_org(user_id, group_name, org_url):

# logger = logging.getLogger(add_org.__name__)

# with GithubTaskSession(logger) as session:
# result = UserRepo.add_github_org_repos(session, org_url, user_id, group_name)

# print(org_url, result)












Loading