fix(#3577): remove shell=True and convert commands to argument lists to prevent command injection #3578
+43
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shlokgilda
requested changes
Jan 15, 2026
Collaborator
shlokgilda
left a comment
shlokgilda
left a comment
There was a problem hiding this comment.
took a look at this - the fix is solid. nice catch on the shell=True issue.
couple notes from testing:
- git itself actually blocks the injection chars (backticks,
$(),;) in branch names - so the real attack surface was narrower than we initially thought. but|and&are still allowed, which could be exploited withshell=True, so this fix is still the right call. - please confirm the intent behind the switch from
git remote show origin | sedtogit symbolic-ref. - tiny nit:
cmd: listcould becmd: list[str]for better type hints
…lists to prevent command injection Signed-off-by: guptapratykshh <pratykshgupta9999@gmail.com>
…trict typing Replaces git symbolic-ref with git remote show origin parsed in Python to ensure accuracy while preventing command injection. Updates type hints. Signed-off-by: guptapratykshh <pratykshgupta9999@gmail.com>
guptapratykshh
force-pushed
the
fix/command-injection-facade-worker
branch
from
b1913f4 to
3da58ce
Compare
shlokgilda
requested changes
Jan 15, 2026
Collaborator
shlokgilda
left a comment
shlokgilda
left a comment
There was a problem hiding this comment.
PR looks good. Once you create the helper function, I think we are GTG
…code Signed-off-by: guptapratykshh <pratykshgupta9999@gmail.com>
guptapratykshh
force-pushed
the
fix/command-injection-facade-worker
branch
from
1ca8aad to
a71e04f
Compare
MoralCode
reviewed
Jan 15, 2026
Contributor
MoralCode
left a comment
MoralCode
left a comment
There was a problem hiding this comment.
Overall i like the move to the list-based args and not using shell=True. Theres a couple unrelated changes in here though
|
|
||
| getremotedefault = ( | ||
| f"git -C {absolute_path} remote show origin | sed -n '/HEAD branch/s/.*: //p'") | ||
| getremotedefault = ["git", "-C", absolute_path, "symbolic-ref", "refs/remotes/origin/HEAD"] |
Contributor
There was a problem hiding this comment.
Need to confirm that this is functionally the same
guptapratykshh
force-pushed
the
fix/command-injection-facade-worker
branch
from
b14e877 to
bd88239
Compare
Signed-off-by: guptapratykshh <pratykshgupta9999@gmail.com>
guptapratykshh
force-pushed
the
fix/command-injection-facade-worker
branch
from
bd88239 to
8d7d2a3
Compare
sgoggins
added
the
high priority
MoralCode
reviewed
Jan 21, 2026
Comment on lines
-417
to
+418
| return_code_remote, remotedefault = facade_helper.run_git_command( | ||
| return_code_remote, output = facade_helper.run_git_command( |
Contributor
There was a problem hiding this comment.
this feels like we are maybe duplicating a lot of code here. Can we maybe refactor some of this git access type of stuff into shared functions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this PR fixes #3577 by removing
shell=Truefrom git command execution and converting all f-string commands to argument lists infacade worker.Signed commits