Populate null columns in repo_info table #3584
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: guptapratykshh <pratykshgupta9999@gmail.com>
sgoggins
requested changes
Jan 20, 2026
Member
sgoggins
left a comment
sgoggins
left a comment
There was a problem hiding this comment.
I would like to see Unit tests written for these functions in a way that validates the existence of the end point and incorporates the use of edge cases. i.e. valid cases with an empty URL, invalid cases where there is not a 404 but its empty, etc.).
| 'issues_enabled': data['hasIssuesEnabled'] if 'hasIssuesEnabled' in data else None, | ||
| 'open_issues': data['issues']['totalCount'] if data['issues'] else None, | ||
| 'pull_requests_enabled': None, | ||
| 'pull_requests_enabled': 'true' if repo_data.get('has_projects') else 'false', |
Member
There was a problem hiding this comment.
We are not using the .get syntax elsewhere. I am not sure I love the nesting, and I agree it is useful to get these data elements we previously ignored.
Can you share a rationale for this design choice?
Contributor
There was a problem hiding this comment.
get syntax is better because it wont crash if the key doesnt exist (will return a default value, which is none by default)
I use it all the time
sgoggins
added
release
MoralCode
removed
release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
added data collection for six null columns in repo_info table -
contributing_file,security_issue_file,changelog_file,keywords,pull_requests_enabled, andpages_enabled.This PR fixes #2675
Notes for Reviewers
Signed commits