fix: prevent theoretical NameError from uninitialized keys variable in github_api_key_handler.py #3603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Initialize keys=[] before retry loop to prevent NameError if all database attempts fail - Replace bare except: with except Exception for better debugging - Add logging for failed database attempts - Remove unused variable assignment (valid_now) and dead commented code Fixes chaoss#3602 Signed-off-by: ANJAN672 <[email protected]>
MoralCode
changed the title
Contributor
|
my understanding from slack was that you havent actually encountered this exception, but noticed it was theoretically possible, so i changed the issue title to reflect that |
sgoggins
reviewed
Jan 20, 2026
| keys = self.get_api_keys_from_database() | ||
| break | ||
| except: | ||
| except Exception as e: |
Member
There was a problem hiding this comment.
I think this may be more effective using except* to capture nested exceptions and decode them all; though I think @ABrain7710 will have the final say on whether or not this is a good idea.
Member
|
If this is not theoretical, can you add the stack, @ANJAN672 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where the
keysvariable inget_api_keys()may be uninitialized, causing aNameError.The Problem
If
get_api_keys_from_database()fails all 3 retry attempts, thekeysvariable was never assigned, causing a crash on line 106:Changes Made
keys = []before the retry loop - Prevents NameError if all attempts failexcept:withexcept Exception as e:- Avoids catching system exceptions like KeyboardInterruptvalid_nowvariable and commented-out codeTesting
Related
Fixes #3602
Signed commits